[llvm] r344298 - [llvm-pdbutil] Pretty print PDBSymbolUsingNamespace symbols

Aaron Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 14:37:18 PDT 2018


Author: asmith
Date: Thu Oct 11 14:37:18 2018
New Revision: 344298

URL: http://llvm.org/viewvc/llvm-project?rev=344298&view=rev
Log:
[llvm-pdbutil] Pretty print PDBSymbolUsingNamespace symbols

Reviewers: rnk, zturner, llvm-commits

Differential Revision: https://reviews.llvm.org/D52799

Added:
    llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp
    llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.pdb
    llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test
Modified:
    llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp
    llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h

Added: llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp?rev=344298&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp (added)
+++ llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp Thu Oct 11 14:37:18 2018
@@ -0,0 +1,11 @@
+// Compile with "cl /c /Zi /GR- UsingNamespaceTest.cpp"
+// Link with "link UsingNamespaceTest.obj /debug /nodefaultlib /entry:main"
+
+namespace NS {
+  int foo() { return 1; }
+}
+
+using namespace NS;
+int main(int argc, char **argv) {
+  return foo();
+}

Added: llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.pdb
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.pdb?rev=344298&view=auto
==============================================================================
    (empty)

Added: llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test?rev=344298&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test (added)
+++ llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test Thu Oct 11 14:37:18 2018
@@ -0,0 +1,6 @@
+; RUN: llvm-pdbutil pretty -module-syms %p/Inputs/UsingNamespaceTest.pdb > %t
+; RUN: FileCheck -input-file=%t %s
+
+; CHECK: ---SYMBOLS---
+; CHECK-NEXT: {{.*}}UsingNamespaceTest.obj
+; CHECK-DAG: using namespace NS

Modified: llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp?rev=344298&r1=344297&r2=344298&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp (original)
+++ llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp Thu Oct 11 14:37:18 2018
@@ -28,6 +28,7 @@
 #include "llvm/DebugInfo/PDB/PDBSymbolThunk.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolTypeFunctionSig.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolUnknown.h"
+#include "llvm/DebugInfo/PDB/PDBSymbolUsingNamespace.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
@@ -216,3 +217,13 @@ void CompilandDumper::dump(const PDBSymb
   Printer.NewLine();
   Printer << "unknown (" << Symbol.getSymTag() << ")";
 }
+
+void CompilandDumper::dump(const PDBSymbolUsingNamespace &Symbol) {
+  if (Printer.IsSymbolExcluded(Symbol.getName()))
+    return;
+
+  Printer.NewLine();
+  Printer << "using namespace ";
+  std::string Name = Symbol.getName();
+  WithColor(Printer, PDB_ColorItem::Identifier).get() << Name;
+}

Modified: llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h?rev=344298&r1=344297&r2=344298&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h (original)
+++ llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h Thu Oct 11 14:37:18 2018
@@ -34,6 +34,7 @@ public:
   void dump(const PDBSymbolThunk &Symbol) override;
   void dump(const PDBSymbolTypeTypedef &Symbol) override;
   void dump(const PDBSymbolUnknown &Symbol) override;
+  void dump(const PDBSymbolUsingNamespace &Symbol) override;
 
 private:
   LinePrinter &Printer;




More information about the llvm-commits mailing list