[PATCH] D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 13:08:47 PDT 2018


delcypher added a comment.

In https://reviews.llvm.org/D53111#1261287, @kubamracek wrote:

> What breaks if we switch to the absolute path on Linux?


I'm not sure. I will test and report back.



================
Comment at: test/asan/lit.cfg:108-113
+  shared_libasan_path = os.path.join(
+    config.compiler_rt_libdir,
+    'libclang_rt.asan_{}_dynamic.dylib'.format(
+      config.apple_platform
+    )
+  )
----------------
kubamracek wrote:
> This is unnecessarily expanded. Fold at least the .format() call into one line (personally I'd have this whole thing on one line).
Sure. I'll fix this.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53111





More information about the llvm-commits mailing list