[PATCH] D53098: [InstCombine] Avoid instruction sinking if not profitable for other passes

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D53098#1262408, @xbolva00 wrote:

> I will precommit them if folks say this is fine direction to go.


If no existing test is affected by this, you most likely want the tests anyway.

> If we sink the call instructions, Florian's new SCCP patches related to null checks optimizations are unable to benefit from the dominating call with nonnull args.
> 
> Florian disabled sinking to see the potential of his new SCCP optimizations, but we need a stronger solution (to not regress in other areas).




https://reviews.llvm.org/D53098