[PATCH] D53159: [buildbot, windows] Pass the python path for the new windows buildbot correctly

Stella Stamenova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 12:04:46 PDT 2018


stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, gkistanova.
Herald added a subscriber: llvm-commits.

Right now the path is passed to CMake as a string without quotes causing CMake to fail to find python


Repository:
  rL LLVM

https://reviews.llvm.org/D53159

Files:
  buildbot/osuosl/master/config/builders.py


Index: buildbot/osuosl/master/config/builders.py
===================================================================
--- buildbot/osuosl/master/config/builders.py
+++ buildbot/osuosl/master/config/builders.py
@@ -993,8 +993,7 @@
          'category' : 'lldb',
          'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory(
                     clean=True,
-                    python_source_dir="C:\\Program Files (x86)\\Microsoft Visual Studio\\Shared\\Python36_64",
-                    vs='%VS150COMNTOOLS%',
+                    python_source_dir=r'"C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64"',
                     target_arch='x64',
                     test=True,
                     extra_cmake_args=['-DLLVM_ENABLE_ASSERTIONS=OFF'])}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53159.169269.patch
Type: text/x-patch
Size: 771 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/6fb00b63/attachment.bin>


More information about the llvm-commits mailing list