[PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization

[Zachary Turner via llvm-commits]

I have a repro.  It's more complicated than I was hoping for to fix.  I'm
still trying, but if it doesn't lend itself to a fix in the next half hour
or so I'm going to mark the tests as XFAIL on non-Windows while I continue
working on it.

On Thu, Oct 11, 2018 at 10:14 AM Stella Stamenova <stilis at microsoft.com>
wrote:

> I took a quick look at the FileCheck issue and it looks like these have
> been failing since mid-September!
>
>
>
> That’s when the change to use filecheck inside the LLDB tests as a
> function went in: https://reviews.llvm.org/D50751. The change adds a new
> required input to dotests.py and updates the cmake files to pass it as well
> as the xcode project, but any of the bots that are calling dotests.py
> directly now need to pass the new input too.
>
>
>
> Vedant, since you made the change, how do you feel about logging a warning
> instead of hard failing inside dotests.py and then hardfailing any tests
> that use filecheck when it doesn’t exist? That would limit the failures
> just to those tests instead of all of the tests on these bots. The bot
> owners will have to update the scripts as well.
>
>
>
> Zachary, if you can’t get a local repro of the windows or linux failure
> with your changes, I can get you the logs from our test runs.
>
>
>
> Thanks,
>
> -Stella
>
>
>
> *From:* Zachary Turner <zturner at google.com>
> *Sent:* Wednesday, October 10, 2018 8:23 PM
> *To:* reviews+D53002+public+9ea58f85247e05d8 at reviews.llvm.org
> *Cc:* aleksandr.urakov at jetbrains.com; aaron.lee.smith <
> aaron.lee.smith at gmail.com>; Stella Stamenova <stilis at microsoft.com>;
> pavel at labath.sk; mosescu at google.com; mgorny at gentoo.org; arphaman at gmail.com;
> llvm-commits at lists.llvm.org; llvm at inglorion.net
> *Subject:* Re: [PATCH] D53002: Create a new symbol file plugin for
> cross-platform PDB symbolization
>
>
>
>
>
> On Wed, Oct 10, 2018 at 3:34 PM Stella Stamenova via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> stella.stamenova added a comment.
>
> Not sure if you've noticed this yet, but a couple of the new tests are
> failing on Linux and one of them is failing on Windows as well. The
> failures on Linux are in disassembly.cpp and source-list.cpp and
> source-list.cpp is also failing on Windows. Let me know if you need logs
> from the failures.
>
>
>
> It seems none of the bots that run tests currently work, but for an
> unrelated reason.  I wonder if anyone is looking into this?  They all
> complain about a missing FileCheck executable.  Since I can't see the Linux
> failures, I'll have to wait until tomorrow to reproduce those.  I can fix
> the Windows one (hopefully) by regex'ing out the absolute path.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/ece96e55/attachment.html>