[PATCH] D53056: [MC][ELF] compute entity size for explicit sections

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 10:04:30 PDT 2018


nickdesaulniers added a comment.

Thanks for the report, and sorry for adding a red test on OSX.  The name of the section is not the important part (it could be called `"foo"`) of the test, just that it have a custom section.  The IR from the test is from real code from the Linux kernel.  If the format from the error `a segment and section separated by a comma` is valid on Linux, then that should be fine.  But I guess then this issue pops up again for Windows, or anywhere else that doesn't use ELF?  So this probably should be made into an ELF only test.

I'll look into how to do that, but appreciate any tips.


Repository:
  rL LLVM

https://reviews.llvm.org/D53056





More information about the llvm-commits mailing list