[PATCH] D53134: [tblgen][llvm-mca] Add the ability to describe move elimination candidates via tablegen.

[Matt Davis via Phabricator via llvm-commits]

mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.

This LGTM!  I didn't have much to say, your descriptions were clear, and from what I can tell the changes look good.



================
Comment at: include/llvm/Target/TargetSchedule.td:463
 //  - The cost of a register rename.
+//  - The set of registers that allow move elimination
+//  - The maximum number of moves that can be eliminated every cycle.
----------------
nit: Add a period to the end of this line. 


================
Comment at: include/llvm/Target/TargetSchedule.td:515
+// Field MaxMovesEliminatedPerCycle specifies how many moves can be eliminated
+// every cycle. A default value of zero for that field means: ther is no limit
+// to the number of moves that can be eliminated by this register file.
----------------
s/ther/there/


================
Comment at: include/llvm/Target/TargetSchedule.td:527
+// A register move MI is eliminated only if:
+//  - MI is a move elimination candidate
+//  - The destination register is from a register class that allows move
----------------
nit: Add a period to the end of this line. 


https://reviews.llvm.org/D53134