[PATCH] D53064: [llvm-nm] Include the text "@FILE" in the output of --help

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 23:55:45 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL344222: [llvm-nm] Include the text "@FILE" in the output of --help (authored by mstorsjo, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53064?vs=169082&id=169157#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53064

Files:
  llvm/trunk/test/tools/llvm-nm/X86/response-file.test
  llvm/trunk/test/tools/llvm-nm/libtool-response-file.test
  llvm/trunk/tools/llvm-nm/llvm-nm.cpp


Index: llvm/trunk/test/tools/llvm-nm/libtool-response-file.test
===================================================================
--- llvm/trunk/test/tools/llvm-nm/libtool-response-file.test
+++ llvm/trunk/test/tools/llvm-nm/libtool-response-file.test
@@ -0,0 +1,4 @@
+RUN: llvm-nm --help | FileCheck %s
+Check that the output of llvm-nm --help contains the literal text @FILE; this
+indicates to libtool that llvm-nm does support response files.
+CHECK: @FILE
Index: llvm/trunk/test/tools/llvm-nm/X86/response-file.test
===================================================================
--- llvm/trunk/test/tools/llvm-nm/X86/response-file.test
+++ llvm/trunk/test/tools/llvm-nm/X86/response-file.test
@@ -0,0 +1,5 @@
+# RUN: echo "-P %p/Inputs/hello.obj.elf-x86_64" > %t-response
+# RUN: llvm-nm @%t-response | FileCheck %s
+
+CHECK: main T 0 0
+CHECK: puts U 0 0
Index: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
===================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp
@@ -183,6 +183,8 @@
 cl::opt<bool> NoLLVMBitcode("no-llvm-bc",
                             cl::desc("Disable LLVM bitcode reader"));
 
+cl::extrahelp HelpResponse("\nPass @FILE as argument to read options from FILE.\n");
+
 bool PrintAddress = true;
 
 bool MultipleFiles = false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53064.169157.patch
Type: text/x-patch
Size: 1344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/52877eaa/attachment.bin>


More information about the llvm-commits mailing list