[PATCH] D53093: [WebAssembly][NFC] Remove repetition of Defs = [ARGUMENTS]

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 12:32:28 PDT 2018


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.td:168
+  let hasSideEffects = 1, isCodeGenOnly = 1,
+      Defs = []<Register>, Uses = [ARGUMENTS] in
   defm ARGUMENT_#vt : I<(outs vt:$res), (ins i32imm:$argno),
----------------
aheejin wrote:
> What's this `Defs`?
An empty list (with type annotation to keep tablegen happy). AFAIK, `ARGUMENT` is the only class of instructions that should not have `Defs = [ARGUMENTS]`, this line overrides the new default.


Repository:
  rL LLVM

https://reviews.llvm.org/D53093





More information about the llvm-commits mailing list