[PATCH] D53093: [WebAssembly][NFC] Remove repetition of Defs = [ARGUMENTS]

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrFormats.td:55
   def _S : NI<oops_s, iops_s, [], 1, asmstr_s, inst>;
+  } // Defs = [ARGUMENTS]
 }
----------------
There seem to be [[ https://github.com/llvm-mirror/llvm/blob/ca0c32a3b8c810d7e315661a48b070c5ac2fa150/lib/Target/WebAssembly/WebAssemblyInstrControl.td#L51-L75 | some instructions ]] that directly derive from not `I` but `NI`. Maybe we should put this in `NI`?


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.td:168
+  let hasSideEffects = 1, isCodeGenOnly = 1,
+      Defs = []<Register>, Uses = [ARGUMENTS] in
   defm ARGUMENT_#vt : I<(outs vt:$res), (ins i32imm:$argno),
----------------
What's this `Defs`?


Repository:
  rL LLVM

https://reviews.llvm.org/D53093