[PATCH] D52426: [X86] Move X86DAGToDAGISel::matchBEXTRFromAnd() into X86ISelLowering

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 04:33:44 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35249
+                                        const X86Subtarget &Subtarget) {
+  assert(Node->getOpcode() == ISD::AND);
+
----------------
asserts should have a message


================
Comment at: test/CodeGen/X86/bmi-x86_64.ll:105
 
 define i64 @non_bextr64(i64 %x) {
+; BEXTR-SLOW-LABEL: non_bextr64:
----------------
Why is this call non_bextr64?


Repository:
  rL LLVM

https://reviews.llvm.org/D52426





More information about the llvm-commits mailing list