[PATCH] D53017: [LLD] [COFF] Look for libfoo.a if foo.lib is specified, for MinGW

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 02:21:05 PDT 2018


mstorsjo added inline comments.


================
Comment at: COFF/Driver.cpp:380
     Filename = Saver.save(Filename + ".lib");
-  return doFindFile(Filename);
+  StringRef Ret = doFindFile(Filename);
+  if (Config->MinGW && Ret == Filename && HasExt && !Filename.contains('/') &&
----------------
ruiu wrote:
> Please add a comment to explain this mingw-specific behavior. It might be a good thing to separate this code as a new function.
Ok, I added more comments and split this to a separate function, before pushing.


Repository:
  rL LLVM

https://reviews.llvm.org/D53017





More information about the llvm-commits mailing list