[PATCH] D52923: AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:51
   const LLT PrivatePtr = GetAddrSpacePtr(AMDGPUAS::PRIVATE_ADDRESS);
+  const LLT P7 = GetAddrSpacePtr(7);
 
----------------
This should get a new enum value?


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:274
+    return true;
+  case AMDGPUIntrinsic::SI_load_const: {
+    MachineFunction &MF = MIRBuilder.getMF();
----------------
Should we really be adding support for the old/broken intrinsics here?


Repository:
  rL LLVM

https://reviews.llvm.org/D52923