[PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 168897.
zturner added a comment.

Use `lldbassert`.  The main reason I didn't use this originally is because it didn't used to be a hard assert.  But since it seems like it is now, I've no problem standardizing on this.

(FWIW, I actually think we should call `llvm::sys::report_fatal_error` instead of `abort`, but we can have that discussion another time.


https://reviews.llvm.org/D53002

Files:
  lldb/include/lldb/Utility/LLDBAssert.h
  lldb/lit/SymbolFile/NativePDB/Inputs/breakpoints.lldbinit
  lldb/lit/SymbolFile/NativePDB/Inputs/disassembly.lldbinit
  lldb/lit/SymbolFile/NativePDB/Inputs/source-list.lldbinit
  lldb/lit/SymbolFile/NativePDB/disassembly.cpp
  lldb/lit/SymbolFile/NativePDB/lit.local.cfg
  lldb/lit/SymbolFile/NativePDB/simple-breakpoints.cpp
  lldb/lit/SymbolFile/NativePDB/source-list.cpp
  lldb/lit/lit.cfg
  lldb/source/Plugins/SymbolFile/CMakeLists.txt
  lldb/source/Plugins/SymbolFile/NativePDB/CMakeLists.txt
  lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.h
  lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.h
  lldb/source/Plugins/SymbolFile/NativePDB/PdbSymUid.h
  lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.h
  lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
  lldb/source/Plugins/SymbolFile/PDB/CMakeLists.txt
  lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53002.168897.patch
Type: text/x-patch
Size: 84010 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181009/4e8fe6b5/attachment-0001.bin>