[PATCH] D53044: [ELF] Don't warn on undefined symbols when reading call graph profile

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 15:36:06 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D53044#1259600, @ruiu wrote:

> I don't think I understand the point of this patch. You can't reorder undefined symbols, so why does CG-profile section contains undefined symbol in the first place?


My understanding is that if you link an executable, all .cg_profile symbols should be defined. However, with `-shared`, it is possible that only partial object files are linked and some symbols are left undefined. By separating From and To symbols into different modules, the `.cg_profile From, To, count` directives are essentially rendered useless, but I feel this is intended and no warnings should be given.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53044





More information about the llvm-commits mailing list