[PATCH] D53017: [LLD] [COFF] Look for libfoo.a if foo.lib is specified, for MinGW

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 14:31:38 PDT 2018


ruiu added inline comments.


================
Comment at: COFF/Driver.cpp:380
     Filename = Saver.save(Filename + ".lib");
-  return doFindFile(Filename);
+  StringRef Ret = doFindFile(Filename);
+  if (Config->MinGW && Ret == Filename && HasExt && !Filename.contains('/') &&
----------------
Please add a comment to explain this mingw-specific behavior. It might be a good thing to separate this code as a new function.


https://reviews.llvm.org/D53017





More information about the llvm-commits mailing list