[PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 14:13:17 PDT 2018


zturner added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:571-572
+
+    if (!IsValidRecord(proc))
+      continue;
+
----------------
@stella.stamenova I added the sanitization check here for the record.  In theory we can provide an overload of this function for every record type that has special requirements.  For now I've only implemented the function for this record type and all other types return `true`.


https://reviews.llvm.org/D53002





More information about the llvm-commits mailing list