[PATCH] D49691: [DAGCombine] Allow alias analysis with inline asm calls and GluedNodes.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 13:17:53 PDT 2018


hfinkel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18792
                                    SmallVectorImpl<SDValue> &Aliases) {
-  SmallVector<SDValue, 8> Chains;     // List of chains to visit.
-  SmallPtrSet<SDNode *, 16> Visited;  // Visited node set.
+  SmallVector<std::pair<SDValue, SDValue>, 16>
+      Chains;                        // List of chains to visit.
----------------
Please document here what each member of the pair represents.


Repository:
  rL LLVM

https://reviews.llvm.org/D49691





More information about the llvm-commits mailing list