[PATCH] D53031: Expand comment for MinGW driver.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 11:43:52 PDT 2018


smeenai added inline comments.


================
Comment at: lld/MinGW/Driver.cpp:26
+// There are subtle differences between MS link.exe and GNU ld/MinGW, and GNU
+// ld/MinGW implemented a few GNU-specific features. Such features are directly
+// implemented in lld/COFF and enabled only when the linker is running in MinGW
----------------
mstorsjo wrote:
> smeenai wrote:
> > implemented -> implements?
> I don't see anything wrong with what's written here at the moment.
It sounds more natural in the present tense to me (it flows better from the previous part of the sentence), but yeah, it's fine either way.


https://reviews.llvm.org/D53031





More information about the llvm-commits mailing list