[llvm] r344005 - PHIElimination: Remove wrong comment; NFC

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 8 16:47:35 PDT 2018


Author: matze
Date: Mon Oct  8 16:47:35 2018
New Revision: 344005

URL: http://llvm.org/viewvc/llvm-project?rev=344005&view=rev
Log:
PHIElimination: Remove wrong comment; NFC

The comment was contradicting the code. Looking at history the feature
was implemented a day after the comment was written without dropping the
comment.

Modified:
    llvm/trunk/lib/CodeGen/PHIElimination.cpp

Modified: llvm/trunk/lib/CodeGen/PHIElimination.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PHIElimination.cpp?rev=344005&r1=344004&r2=344005&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/PHIElimination.cpp (original)
+++ llvm/trunk/lib/CodeGen/PHIElimination.cpp Mon Oct  8 16:47:35 2018
@@ -153,8 +153,7 @@ bool PHIElimination::runOnMachineFunctio
   // This pass takes the function out of SSA form.
   MRI->leaveSSA();
 
-  // Split critical edges to help the coalescer. This does not yet support
-  // updating LiveIntervals, so we disable it.
+  // Split critical edges to help the coalescer.
   if (!DisableEdgeSplitting && (LV || LIS)) {
     MachineLoopInfo *MLI = getAnalysisIfAvailable<MachineLoopInfo>();
     for (auto &MBB : MF)




More information about the llvm-commits mailing list