[PATCH] D52914: [WebAssembly] Added test for inline assembly roundtrip.

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 8 16:37:29 PDT 2018


aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/inline-asm-roundtrip.ll:34
+; CHECK-NEXT:	i32.const	3
+; CHECK-NEXT:	i32.ne
+
----------------
Here the compiler happens to place `src` and `dst` in the same local, but I guess that can't be guaranteed. How about changing them to variables, like
```
; CHECK-NEXT:  i32.const  1
; CHECK-NEXT:  set_local  [[SRC:[0-9]+]]
; CHECK-NEXT:  i32.const  2
; CHECK-NEXT:  get_local  [[SRC]]
; CHECK-NEXT:  i32.add
; CHECK-NEXT:  set_local  [[DST:[0-9]+]]
; CHECK-NEXT:  get_local  [[DST]]
...
```


Repository:
  rL LLVM

https://reviews.llvm.org/D52914





More information about the llvm-commits mailing list