[PATCH] D52985: [mips][micromips] Fix how values in .gcc_except_table are calculated

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/MC/MCExpr.cpp:10
 
+#include "llvm/MC/MCAsmBackend.h"
 #include "llvm/MC/MCExpr.h"
----------------
Is it really necessary to include MCAsmBackend.h and at the same time add forward declaration of class MCAsmBackend below?


================
Comment at: lib/MC/MCExpr.cpp:532
 
+    if (Asm->getBackend().isMicroMips(&SA))
+      Addend |= 1;
----------------
Let's add a comment for these lines (like for lines above).


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.h:21
 #include "llvm/MC/MCAsmBackend.h"
+#include "llvm/MC/MCSymbolELF.h"
 
----------------
Is it really necessary to include MCSymbolELF.h and at the same time add forward declaration of `class MCSymbolELF` below?


Repository:
  rL LLVM

https://reviews.llvm.org/D52985