[PATCH] D52999: [FileCheck] Annotate input dump

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D52999#1258216, @george.karpenkov wrote:

> > I don't know how to test color in the output, so any hints here would be appreciated.
>
> I think almost everyone reads FileCheck output through lit, which strips away all color =(


When I'm really baffled by a FileCheck diagnostic, I find myself running the commands manually, so color is useful then.  We could also consider teaching lit not to strip away color.  In any case, the annotations are usable without color.  Color just makes them easier to read.

But does anyone know of a good way to test colored output?  My test cases here currently only exercise the dump without color.

In https://reviews.llvm.org/D52999#1258217, @george.karpenkov wrote:

> I am also somewhat uneasy about renaming the option, since it is already contained in some configurations. Could we accept both?


I'm fine with that.  To avoid questions of precedence, we could make it an error to specify both versions at the same time.

> In the long term, I think we should introduce the LIT_DEBUG option, which would set both, so typing a long option name would not be necessary.

Sure.  In this patch, I wasn't worried about the length of the option so much.  It's just that the old name doesn't make sense for always mode.


Repository:
  rL LLVM

https://reviews.llvm.org/D52999