[PATCH] D49168: [LV] Add a new reduction pattern match

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D49168#1258185, @hsaito wrote:

> LGTM. Please wait for a few days to give others time to respond if they'd like to.


Thanks Hideki!

I'll update with the review comments and wait a few days.



================
Comment at: test/Transforms/LoopVectorize/if-reduction.ll:1
+; RUN: opt -S -loop-vectorize -instcombine -force-vector-width=4 -force-vector-interleave=1 < %s | FileCheck %s
+
----------------
hsaito wrote:
> My preference is to have vectorization/non-vectorization checked by itself and then have another RUN line to check the expected optimization by InstCombine. That way, we'll quickly know which part changed when the test fails. I don't insist, though.
> 
I see what you mean, will try to separate them. I'm not even sure the instcombine is necessary for the results we check, though.


================
Comment at: test/Transforms/LoopVectorize/if-reduction.ll:583
+; CHECK-LABEL: @fcmp_fadd_fmul(
+; CHECK-NOT: <float> x float>
+define float @fcmp_fadd_fmul(float* nocapture readonly %a, i32 %n) nounwind readonly {
----------------
hsaito wrote:
> Is this the correct check here?
ouch, no, regex left-over. Will fix.


https://reviews.llvm.org/D49168