[PATCH] D52645: [AsmParser] Return an error in the case of empty symbol ref in an expression

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL343961: [AsmParser] Return an error in the case of empty symbol ref in an expression (authored by thegameg, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D52645?vs=167449&id=168632#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D52645

Files:
  llvm/trunk/lib/MC/MCParser/AsmParser.cpp
  llvm/trunk/test/MC/AArch64/expr-bad-symbol.s


Index: llvm/trunk/lib/MC/MCParser/AsmParser.cpp
===================================================================
--- llvm/trunk/lib/MC/MCParser/AsmParser.cpp
+++ llvm/trunk/lib/MC/MCParser/AsmParser.cpp
@@ -1103,7 +1103,7 @@
     // This is a symbol reference.
     StringRef SymbolName = Identifier;
     if (SymbolName.empty())
-      return true;
+      return Error(getLexer().getLoc(), "expected a symbol reference");
 
     MCSymbolRefExpr::VariantKind Variant = MCSymbolRefExpr::VK_None;
 
Index: llvm/trunk/test/MC/AArch64/expr-bad-symbol.s
===================================================================
--- llvm/trunk/test/MC/AArch64/expr-bad-symbol.s
+++ llvm/trunk/test/MC/AArch64/expr-bad-symbol.s
@@ -0,0 +1,6 @@
+// RUN: not llvm-mc -triple aarch64-- %s 2>&1 | FileCheck %s
+
+  .text
+_foo:
+  str q28, [x0, #1*6*4*@]
+// CHECK: error: expected a symbol reference


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52645.168632.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181008/fc1fb5b2/attachment.bin>