[PATCH] D52974: [XRay][compiler-rt] Generational Buffer Management

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 7 22:52:39 PDT 2018


dberris created this revision.
dberris added reviewers: mboerger, eizan.
Herald added a subscriber: jfb.

This change updates the buffer queue implementation to support using a
generation number to identify the lifetime of buffers. This first part
introduces the notion of the generation number, without changing the way
we handle the buffers yet.

What's missing here is the cleanup of the buffers. Ideally we'll keep
the two most recent generations. We need to ensure that before we do any
writes to the buffers, that we check the generation number(s) first.

Those changes will follow-on from this change.

Depends on https://reviews.llvm.org/D52588.


https://reviews.llvm.org/D52974

Files:
  compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc
  compiler-rt/lib/xray/xray_buffer_queue.cc
  compiler-rt/lib/xray/xray_buffer_queue.h
  compiler-rt/lib/xray/xray_fdr_logging.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52974.168611.patch
Type: text/x-patch
Size: 10642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181008/26106dd8/attachment.bin>


More information about the llvm-commits mailing list