[PATCH] D52965: [X86][AVX] Improve vXi64 UITOFP vXf64/vXf32 support (P38226/PR38970)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2362
+  if (!isSigned && SrcVT.getScalarType() == MVT::i64 &&
+      DestVT.getScalarType() == MVT::f64) {
     LLVM_DEBUG(dbgs() << "Converting unsigned i64 to f64\n");
----------------
I think we really need to handle this in the expand code in LegalizeVectorOps. We hit the expand there first which scalarizes it. Then DAG combine reassembled it in reduceBuildVecConvertToConvertBuildVec. The we hit this code in LegalizeDAG. But I don't think we really want to rely on DAG combine like that.


Repository:
  rL LLVM

https://reviews.llvm.org/D52965