[PATCH] D52747: [InstCombine] reverse 'trunc X to <N x i1>' canonicalization

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 6 06:03:45 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D52747#1257240, @RKSimon wrote:

> @craig.topper The final codegen from the updated IR in masked_load_store.ll regresses due to masked stores not making use of only requiring the MSB of the mask vector (lots of SIGN_EXTEND_INREG etc.) - X86ISelLowering's combineMaskedStore only handles the PCMPGT case, how tricky would it be to replace it with a general SimplifyDemandedBits calls?


I have a draft of that patch in progress. Let me add some tests, clean it up, and post it. That's the only regression that I'm aware of from this patch, so we can make this patch dependent on that one.


https://reviews.llvm.org/D52747





More information about the llvm-commits mailing list