[PATCH] D52836: [LTO] Account for overriding lib calls via the alias attribute

[Warren Ristow via Phabricator via llvm-commits]

wristow added a comment.

In https://reviews.llvm.org/D52836#1256581, @tejohnson wrote:

> I'll respond more on the bug (especially since I can't reproduce the actual link time error), ...


Thanks for that.  I've responded more thoroughly in the bug, but a short note here to clarify.

The reason the link-time error wasn't reproducible appears to be a new LTO API vs old LTO API issue (as you suggested in the PR).  Also, I agree that your point about `-fno-builtin` etc. means clang can use the intrinsics, and thus the user cannot depend on the overriding happening.

So in a sense, it comes down to whether we want to make the old LTO API behave like the new one does for situations like this.  If the answer is no, then I'll abandon this patch.  If the answer is yes, then this appears to work, but maybe there is a better way (e.g., a way for the old API to be driven to make the link pass).


https://reviews.llvm.org/D52836