[PATCH] D52931: [LLD] [COFF] Don't warn about both main and wmain in MinGW configurations

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 12:36:22 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D52931#1256687, @ruiu wrote:

> This function is called only when you did not pass `/entry:`.
>
> If MinGW uses only mainCRTStartup or WinMainCRTStartup, can you determine which is the case just by looking at a command line? If so, I'd always explicitly pass `/entry:` to the lld-link driver from the mingw driver.


We could do that, but that departs a bit from what the gcc driver passes to ld.bfd. However I took a closer look at what ld.bfd actually does wrt this, and we can emulate it much better.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52931





More information about the llvm-commits mailing list