[PATCH] D52881: [LV] Do not create SCEVs on broken IR in emitTransformedIndex. PR39160

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 11:56:42 PDT 2018


hsaito added a comment.

In https://reviews.llvm.org/D52881#1256586, @fhahn wrote:

> Thanks LGTM. Please wait with committing a bit, in case Hideki or anyone else has any additional comments.


+1. Thanks, @mkazantsev. I think this is a good small incremental fix. If really needed (i.e., others like InstCombine refuses to improve whatever shortcomings exposed), we can add more peephole optimization ---- but I sincerely hope we don't have to do it. Induction simplification is generally useful.


https://reviews.llvm.org/D52881





More information about the llvm-commits mailing list