[PATCH] D52935: [SelectionDAG] Add SimplifyDemandedBits to SimplifyDemandedVectorElts simplification

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 10:17:55 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1213
+    // TODO - bigendian once we have test coverage.
+    // TODO - bool vectors once SimplifyDemandedVectorElts has SETCC support.
+    if (SrcVT.isVector() && NumSrcEltBits > 1 &&
----------------
craig.topper wrote:
> What exactly happens if you add bool vectors in today?
Mainly a load of extra gpr ANDs and kmask KSHIFTL/KSHIFTR


Repository:
  rL LLVM

https://reviews.llvm.org/D52935





More information about the llvm-commits mailing list