[PATCH] D52893: [ThinLTO] Keep non-prevailing (linkonce|weak)_odr symbols live

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

This seems reasonable - we should be able to keep ODR non-prevailing defs around to optimize with. I assume this is a missed optimization fix and not a correctness fix (i.e. the build currently succeeds and builds a correct binary)? Question about that below.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:746
+    // later in the EliminateAvailableExternally pass and setting them to
+    // not-live could break downstreams users of liveness information (PR36483)
+    // or limit optimization opportunities.
----------------
Are you fixing another instance of PR36483? If not, then the comment should probably be updated to indicate that this is to fix a missed optimization.


Repository:
  rL LLVM

https://reviews.llvm.org/D52893