[PATCH] D52912: [SelectionDAG] allow FP binops in SimplifyDemandedVectorElts

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1641
+  case ISD::FDIV:
+  case ISD::FREM: {
     APInt SrcUndef, SrcZero;
----------------
arsenm wrote:
> Should this also handle the unary and ternary ops?
Yes, definitely. But I'm planning to extend this in pieces to limit risk. As we're seeing in this patch, and I found in a draft patch that included ISD::MUL, we have potential regressions as a result of improving this transform. I'm hoping that's a quirk of x86 only, but I can't say for sure because other targets don't seem to have regression tests that are affected.


https://reviews.llvm.org/D52912