[PATCH] D52899: [TTI] Check that lowered type is floating point before calling isFabsFree

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/X86/software-float.ll:6
+
+; RUN: opt -slp-vectorizer -S %s
+
----------------
sbc100 wrote:
> efriedma wrote:
> > Probably should call FileCheck to make sure the code is actually vectorized the way you expect.
> I actually don't know if it successfully vectorizing.  I think we only really care that this doesn't crash here don't we?
No, tests that don't check anything are considered bad form. You can also make this testcase a lot smaller. You may want/need to set the cost threshold to a negative value to force it


Repository:
  rL LLVM

https://reviews.llvm.org/D52899