[PATCH] D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 17:53:42 PDT 2018


MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:155
+  if (UncompressedSize >= 0 && !UncompressedBuf)
+    const_cast<InputSectionBase *>(this)->uncompress();
+  return RawData;
----------------
It seems `uncompress()` is only called once. What do you think if `uncompress()` is inlined here and these mutable member variables are marked as `mutable`?



https://reviews.llvm.org/D52917





More information about the llvm-commits mailing list