[PATCH] D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 16:57:28 PDT 2018


dblaikie added a comment.

Out of curiosity - there's one relocation in each pubnames contribution. Does this solution (or future intended work) manage to avoid decompressing all the input compressed sections into memory, to then apply the relocation, and then write out the buffer (instead either streaming compressed bytes from input to output (either recompressing along the way, or not, as needed))?

Would be great to hear that this generalizes/handles relocations - to help with other compressed debug sections as well.

Though there are some debug sections which may have no relocations (debug_loclists and debug_rnglists maybe, debug_abbrev for sure) which would benefit even if this doesn't help sections with relocs.


https://reviews.llvm.org/D52917





More information about the llvm-commits mailing list