[PATCH] D52831: [lit] Only return a found bash executable on Windows if it can understand Windows paths

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Running cmd.exe is probably even less supported than running bash. If someone is accidentally using execute_external=True, I'd prefer it if they kept using bash and not cmd. So, I'd stick with the first patch.

There are only 111 instances of REQUIRES.*shell in the LLVM monorepo today. We should push all the remaining ones to invoke `sh -c ...` directly for the shell they need, and make the internal lit shell the default lit shell implementation everywhere. It'll simplify lit code and make tests more portable.


https://reviews.llvm.org/D52831