[PATCH] D52793: Introduce internal_sysctlbyname in place of sysctlbyname

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 13:29:20 PDT 2018


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/sanitizer_common/sanitizer_netbsd.cc:96
   CHECK(real_##func);
 #define DEFINE_INTERNAL(ret_type, func, ...) \
   ret_type internal_##func(__VA_ARGS__)
----------------
I don't see how DEFINE_INTERNAL is helpful

the following looks better:
uptr internal_mmap(void *addr, uptr length, int prot, int flags, int fd, OFF_T offset) {
}



Repository:
  rL LLVM

https://reviews.llvm.org/D52793





More information about the llvm-commits mailing list