[PATCH] D52862: DwarfDebug: Pick next location in case of missing location at block begin
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 4 11:34:02 PDT 2018
vsk added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1317
+static const DebugLoc &
+findNextDebugLoc(MachineBasicBlock::const_iterator MBBI,
+ MachineBasicBlock::const_iterator MBBE) {
----------------
MatzeB wrote:
> vsk wrote:
> > Why not use MachineBasicBlock::findDebugLoc?
> As far as I can tell `findDebugLoc` will only give you the DebugLoc of the next non-DEBUG_VALUE instruction. This here will work better if there are mutliple instructions without DebugLoc in sequence.
Sounds good.
Repository:
rL LLVM
https://reviews.llvm.org/D52862
More information about the llvm-commits
mailing list