[PATCH] D52862: DwarfDebug: Pick next location in case of missing location at block begin

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D52862#1255533, @MatzeB wrote:

> In https://reviews.llvm.org/D52862#1255529, @vsk wrote:
>
> > The core idea and test updates look good to me. I'm curious about the size changes: are you just measuring the size of executables, or of .o's? If it's the former, on Darwin, any size change resulting from this patch might indicate bugs.
>
>
> I measured executable sizes. I tried some flags of `llvm-size` or `llvm-dwarfdump` but could not figure out how to measure the size of the line tables directly...


llvm-objdump -h is what I usually use. 'bloaty' (a 3rd party tool) does slightly more precise accounting, though (can account for object file headers, etc), but only ELF I think. Be sure to measure both the section and the .rela section containing the relocations - though I suppose your change shouldn't be changing the number of relocations.

(& absolute changes - compared to the file size as a whole, as well as changes within the section are useful measures)


Repository:
  rL LLVM

https://reviews.llvm.org/D52862