[PATCH] D52886: [X86] Move ReadAfterLd functionality into X86FoldableSchedWrite (PR36957)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 10:42:41 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86SchedBroadwell.td:79
 
+// Vector loads are 5/5/6 cycles, so ReadAfterVec*Ld registers needn't be available
+// until 5/5/6 cycles after the memory operand.
----------------
craig.topper wrote:
> The load latencies on BDW seem weird given that HSW and SKL, the CPUs immediately before and after are the same.
They're the same as BDW's load latencies - can we confirm if they are correct or not? I think this question has come up several times in the past....


================
Comment at: lib/Target/X86/X86SchedSkylakeServer.td:74
 
-// Loads are 5 cycles, so ReadAfterLd registers needn't be available until 5
+// Integer loads are 5 cycles, so ReadAfterLd registers needn't be available until 5
 // cycles after the memory operand.
----------------
craig.topper wrote:
> Why this comment only changed in this model? The same comment existing in SNB, HSW, BDW, and SKLClient.
Because my copy+paste skills are below average.


Repository:
  rL LLVM

https://reviews.llvm.org/D52886





More information about the llvm-commits mailing list