[PATCH] D52829: [AArch64] Fix verifier error when outlining indirect calls

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 10:23:32 PDT 2018


rengolin added a comment.

In https://reviews.llvm.org/D52829#1255435, @paquette wrote:

> OTOH, having a function flag or something like @rengolin suggested is probably a bit cleaner in the long term. I slightly prefer this position since it seems like it should be the verifier's responsibility to understand what to do with an outlined function. Also, if it does turn out that there are other weird cases, it'd be kind of overkill to add special outlining instructions everywhere just to appease the verifier.


Yes, that's what I was worried about.

> So, if it's not too much overhead, I think that adding an outlined function flag or something would probably be better, but for the short-term I'm fine with this.

SGTM, thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D52829





More information about the llvm-commits mailing list