[PATCH] D52828: [doc] Update the programmer's manual about SmallSet's iterator

Umann Kristóf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 05:35:31 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL343770: [doc] Update the programmer's manual about SmallSet's iterator (authored by Szelethus, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D52828?vs=168103&id=168275#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D52828

Files:
  llvm/trunk/docs/ProgrammersManual.rst


Index: llvm/trunk/docs/ProgrammersManual.rst
===================================================================
--- llvm/trunk/docs/ProgrammersManual.rst
+++ llvm/trunk/docs/ProgrammersManual.rst
@@ -1872,21 +1872,19 @@
 :ref:`SmallPtrSet <dss_smallptrset>`.
 
 The magic of this class is that it handles small sets extremely efficiently, but
-gracefully handles extremely large sets without loss of efficiency.  The
-drawback is that the interface is quite small: it supports insertion, queries
-and erasing, but does not support iteration.
+gracefully handles extremely large sets without loss of efficiency.
 
 .. _dss_smallptrset:
 
 llvm/ADT/SmallPtrSet.h
 ^^^^^^^^^^^^^^^^^^^^^^
 
 ``SmallPtrSet`` has all the advantages of ``SmallSet`` (and a ``SmallSet`` of
-pointers is transparently implemented with a ``SmallPtrSet``), but also supports
-iterators.  If more than N insertions are performed, a single quadratically
-probed hash table is allocated and grows as needed, providing extremely
-efficient access (constant time insertion/deleting/queries with low constant
-factors) and is very stingy with malloc traffic.
+pointers is transparently implemented with a ``SmallPtrSet``). If more than N
+insertions are performed, a single quadratically probed hash table is allocated
+and grows as needed, providing extremely efficient access (constant time
+insertion/deleting/queries with low constant factors) and is very stingy with
+malloc traffic.
 
 Note that, unlike :ref:`std::set <dss_set>`, the iterators of ``SmallPtrSet``
 are invalidated whenever an insertion occurs.  Also, the values visited by the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52828.168275.patch
Type: text/x-patch
Size: 1618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181004/a98e9585/attachment.bin>


More information about the llvm-commits mailing list