[PATCH] D43515: More math intrinsics for conservative math handling

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: docs/LangRef.rst:14035
+The '``llvm.experimental.constrained.fptrunc``' intrinsic returns the result of
+a truncating of a floating point operand into a smaller floating point result.
+
----------------
This reads funny. I think it should maybe be "result of truncating a floating point"


================
Comment at: docs/LangRef.rst:14069
+The '``llvm.experimental.constrained.fpext``' intrinsic returns the result of
+an enlarging of a floating point operand.
+
----------------
This also reads funny


================
Comment at: include/llvm/CodeGen/ISDOpcodes.h:528
 
+    STRICT_FP_TO_SINT,
+    STRICT_FP_TO_UINT,
----------------
These need comments. Does STRICT_FP_ROUND have the TRUNC argument that FP_ROUND has? 


https://reviews.llvm.org/D43515