[PATCH] D52837: [WebAssembly] Ignore DBG_VALUE in WebAssemblyCFGStacify pass when looking for block start

Yury Delendik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 14:57:39 PDT 2018


yurydelendik marked an inline comment as done.
yurydelendik added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:313
+    if (std::prev(I)->isDebugInstr())
+      continue;
     if (WebAssembly::isChild(*std::prev(I), MFI))
----------------
aheejin wrote:
> How about `if (std::prev(I)->isDebugInstr() || std::prev(I)->isPosition())` ? The same for the TRY placement. Because labels also can go anywhere and are not stackified.
Added "std::prev(I)->isPosition()". Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D52837





More information about the llvm-commits mailing list