[PATCH] D52845: Update entry count for cold calls

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:770
+  // ones.
+  DenseMap<Instruction *, const FunctionSamples *> coldCalls;
+
----------------
Probably name it differently. They are calls that are inlined in profiled binary but not in optimized binary. 'Coldness' might be just one of the reasons. At least make the comment clearer.


================
Comment at: test/Transforms/SampleProfile/inline-cold.ll:23
+; Function Attrs: nounwind uwtable
+define i32 @_Z3sumii(i32 %x, i32 %y) !dbg !4 {
+entry:
----------------
Add checking of entry profile meta data here.


Repository:
  rL LLVM

https://reviews.llvm.org/D52845