[PATCH] D52744: Add support for GOT relocation support to Hexagon

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

OK, so looks like I cannot agree with the Terms of Use to download the spec. The exact words of the Terms of Use doesn't matter (though I'm not a lawyer), but in general, you cannot require a maintainer to sign a random legal document only to review your patch. Please consider consulting your legal team to make the spec publicly available if you can.

That said, fortunately, the only part I don't understand without the spec is the necessity of R_HEXAGON_GOT relocation type, and as per your explanation, I believe your patch is correct. So, LGTM. Please go ahead and submit.

But again, please consider contacting your legal team to publish the documentation. That makes my life as a maintainer much easier. Thanks!


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52744