[PATCH] D52741: [AMDGPU] Add an AMDGPU pass to promote bitcast calls

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 08:59:01 PDT 2018


scott.linder marked an inline comment as done.
scott.linder added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUFixFunctionBitcasts.cpp:37-38
+    CallSite CS(&CI);
+    if (!CS.getCalledValue())
+      return;
+    if (CS.getCalledFunction())
----------------
arsenm wrote:
> How can this happen?
I'm not entirely sure, but the same check is present in CallSite::isIndirectCall() so I assumed there was a reason. Looking at the implementation I don't see how it is possible, so I will remove it.


https://reviews.llvm.org/D52741





More information about the llvm-commits mailing list