[PATCH] D52724: [ELF] - Do not forget to include to .dymsym symbols that were converted to Defined.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 01:50:25 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D52724#1253355, @orivej wrote:

> Thank you! This patch works as intended.
>
> It seems a bit undesirable that the test generates a warning `cannot find entry symbol _start; defaulting to 0x201000`, and that it expects a possibly unstable number `0x288`, but maybe it's OK.


I'll add the `_start` symbol before commit. Generally, we have test cases which adds it to avoid the warning, but also have tests without. Personally, I have no preference here.


https://reviews.llvm.org/D52724





More information about the llvm-commits mailing list